[SYSTEMDS-3355] MatrixBlock size using CSR when allowed#1593
Closed
Baunsgaard wants to merge 2 commits into
Closed
[SYSTEMDS-3355] MatrixBlock size using CSR when allowed#1593Baunsgaard wants to merge 2 commits into
Baunsgaard wants to merge 2 commits into
Conversation
Baunsgaard
force-pushed
the
SparseCSRSize
branch
from
23f471d to
f046a06
Compare
Contributor
|
I'll have a look in the next days - although I would prefer bringing this in after the release, I think with four eyes and the perftest experiments we should find any potential regression. |
Contributor
|
LGTM - thanks for the patch @Baunsgaard. This is a good improvement of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR change/fix the size estimation to correctly use CSR size if that is allowed.
I have artificially limited it to only cases with more than one column,
since we have code paths that exploit the fact that we do not have any sparse single columns.
I personally would like this merged in, but i can see that it potentially reduce performance in some cases.