[MINOR] Federated monitoring minor bug fixes and documentation #1698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Baunsgaard
reviewed
Sep 25, 2022
Contributor
Baunsgaard
left a comment
Baunsgaard
left a comment
There was a problem hiding this comment.
Overall i think the PR looks good, but there is some minor modifications needed.
...org/apache/sysds/runtime/controlprogram/federated/monitoring/services/StatisticsService.java
Show resolved
Hide resolved
...ava/org/apache/sysds/runtime/controlprogram/federated/monitoring/services/WorkerService.java
Show resolved
Hide resolved
...va/org/apache/sysds/test/functions/federated/monitoring/FederatedBackendPerformanceTest.java
Show resolved
Hide resolved
...java/org/apache/sysds/test/functions/federated/monitoring/FederatedWorkerStatisticsTest.java
Show resolved
Hide resolved
...java/org/apache/sysds/test/functions/federated/monitoring/FederatedWorkerStatisticsTest.java
Outdated
Show resolved
Hide resolved
Contributor
|
Will merge shortly, |
Contributor
|
Unfortunately, the GitHub actions did not include the monitoring tests, and therefore they were never tested in the cloud on your PR and commits. (edit) Link to failing tests: https://github.com/apache/systemds/actions/runs/3154658721/jobs/5132497493 |
fathollahzadeh
pushed a commit
to fathollahzadeh/systemds
that referenced
this pull request
Dec 7, 2022
This commit adds extensions and fixes to the federated monitoring tool. And makes it easier to run via documentation and examples. Closes apache#1698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes issues with multiple threads accessing one derby connection, frontend issues of the dashboard not displaying workers correctly and the event timeline failing completely because of empty event stages.
The change also adds an additional zoom in/out feature for the dashboard, documentation with overview architecture, and how the tool can be started.