[SYSTEMDS-3465] Typed return on CacheBlock Interface Slice #1725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baunsgaard
force-pushed
the
CacheBlock
branch
from
0527554 to
f90499e
Compare
Baunsgaard
changed the title
This commit change the CacheBlock interfaced to by Typed. The change allows cleaner interaction of instructions that are applied to Tensors, Matrices, and Frames such as slice. where previously any cacheBlock could be the argument target for the slice command and potentially any other type could be returned. Now it only allows equal type input and return equal type out. Also cleaned up in this commit is the memory estimates for FrameBlocks, to continue the process of separating the responsibility of the ArrayColumns from the FrameBlock. There are also performance benefits in this commit slightly improving the parsing of Pandas DataFrame into SystemDS DataFrames, but further improvements are planed in future commits.
Baunsgaard
force-pushed
the
CacheBlock
branch
from
f65170a to
0bddf34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit type CacheBlocks, such that we can return subtypes through implementations of the interface.
In practice this means we do not have to cast the MatrixBlock or FrameBlock (or TensorBlock) in instances where we call slice, and therefore do not need to know what type of CacheBlock it is.