Skip to content

Conversation

@BACtaki
Copy link
Contributor

@BACtaki BACtaki commented Nov 19, 2022

This patch adds support for running MULTI_BLOCK aggregations for countDistinct() builtin on the Spark backend. The implementation augments the CountDistinctFunctionSketch with the union() function implementation.

Tests:
[X] Unit tests
[ ] Integration tests
[ ] N/A

… countDistinct()

This patch adds support for running MULTI_BLOCK aggregations for countDistinct() builtin on the Spark backend. The implementation augments the CountDistinctFunctionSketch with the union() function implementation.

Tests:
    [X] Unit tests
    [ ] Integration tests
    [ ] N/A
Copy link
Contributor

@Baunsgaard Baunsgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Baunsgaard
Copy link
Contributor

I have just merged it,
we can add more tests / missing tests in future PR.

@Baunsgaard Baunsgaard closed this in 15df58f Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants