[SYSTEMDS-3473] Push down rmvars for asynchronous instructions #1745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch repositions the rmvar instructions for the inputs to an asynchronous instruction after the consumers of the asynchronous instruction. This change allows keeping the inputs to an asynchronous operator alive until get() is called for the future object. Moreover, this patch adds more tests for the new operator ordering and fixes minor bugs.
fathollahzadeh
pushed a commit
to fathollahzadeh/systemds
that referenced
this pull request
Dec 7, 2022
This patch repositions the rmvar instructions for the inputs to an asynchronous instruction after the consumers of the asynchronous instruction. This change allows keeping the inputs to an asynchronous operator alive until get() is called for the future object. Moreover, this patch adds more tests for the new operator ordering and fixes minor bugs. Closes apache#1745
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch repositions the rmvar instructions for the inputs to an asynchronous instruction after the consumers of the asynchronous instruction. This change allows keeping the inputs to an asynchronous operator alive until get() is called for the future object. Moreover, this patch adds more tests for the new operator ordering and fixes minor bugs.