[MINOR] Adding decision tree to cleaning pipelines evaluation #1881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baunsgaard
reviewed
Aug 10, 2023
Contributor
Baunsgaard
left a comment
Baunsgaard
left a comment
There was a problem hiding this comment.
I think the error is in the Python parsers. that is not robust for all kinds of syntax of the function definitions.
| # ---------------------------------------------------------------------------------------- | ||
|
|
||
| m_vectorToCsv = function(Matrix[Double] mask) | ||
| m_vectorToCsv = function(Matrix[Double] mask = as.matrix(0), Integer n=1) |
Contributor
There was a problem hiding this comment.
the error is here, or rather the parsers we have in Python does not like this syntax.
Contributor
Author
yes, I have added a parameter to an existing function and now the Python parser is failing. I am cleaning the PR to get rid of that parameter and then hopefully everything would work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge as this PR require some cleanups.