[SYSTEMDS-3631] Fix Integer casting bug in as.frame #1923
Closed
+87
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the bug by solidify the isType detection to not allow casting to int on integers above Integer.MAX_VALUE and not cast to long on above Long.MAX_VALUE. Also added is a few tests to verify the behavior in some edge cases.
Contributor
|
Looks good to me and thanks for adding the test such that these issues don't happen again. |
Contributor
|
Feel free to merge it in yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the bug by solidifying the isType detection to not allow casting to int on integers above Integer.MAX_VALUE and not cast to long on above Long.MAX_VALUE. Also added is a few tests to verify the behavior in some edge cases.