[SYSTEMDS-3632] Sparse Reuse of RowVectors #1924
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had an issue when reusing sparseRowVectors, where the maximum number of non zeros in a Sparse Row is set to the number of columns for the parent SparseMCSR Block. But when reusing the rows in allocations of append with other sparse blocks some edge cases increased the number of non zero values above the number of columns in the original matrix. to fix this i made a few changes inside the Sparse CSR blocks, and while at it made an mini optimization of the posFIndexGTE(int r, int c), method to reduce the number of if statements improving overall performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue when reusing sparseRowVectors, where the maximum number of non zeros in a Sparse Row is set to the number of columns for the parent SparseMCSR Block. But when reusing the rows in allocations of append with other sparse blocks some edge cases increased the number of non zero values above the number of columns in the original matrix.
to fix this i made a few changes inside the Sparse CSR blocks, and while at it made an mini optimization of the posFIndexGTE(int r, int c), method to reduce the number of if statements improving overall performance.