Extend test coverage for sparse matrix block representations and related improvements#2406
Open
jessicapriebe wants to merge 16 commits intoapache:mainfrom
Open
Extend test coverage for sparse matrix block representations and related improvements#2406jessicapriebe wants to merge 16 commits intoapache:mainfrom
jessicapriebe wants to merge 16 commits intoapache:mainfrom
Conversation
…parseBlock DCSR checkValidity
Baunsgaard
approved these changes
Jan 21, 2026
Contributor
Baunsgaard
left a comment
There was a problem hiding this comment.
LGTM good job, as I said in the comments, I am a bit horrified about some of the bugs found (probably left by me at some point)
But there are nevertheless some cleanups that could be done while you are at it.
src/main/java/org/apache/sysds/runtime/data/SparseBlockFactory.java
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2406 +/- ##
============================================
+ Coverage 71.51% 71.78% +0.27%
- Complexity 47441 47645 +204
============================================
Files 1539 1539
Lines 182605 182671 +66
Branches 35916 35937 +21
============================================
+ Hits 130585 131136 +551
+ Misses 42028 41530 -498
- Partials 9992 10005 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch expands test coverage for all supported sparse matrix block representations, with minor code extensions and fixes.