[MINOR] Reduce logging in MLContextTests#2432
Open
Baunsgaard wants to merge 2 commits intoapache:mainfrom
Open
[MINOR] Reduce logging in MLContextTests#2432Baunsgaard wants to merge 2 commits intoapache:mainfrom
Baunsgaard wants to merge 2 commits intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2432 +/- ##
============================================
- Coverage 71.55% 71.39% -0.16%
+ Complexity 47461 47368 -93
============================================
Files 1539 1539
Lines 182631 182631
Branches 35919 35919
============================================
- Hits 130677 130397 -280
- Misses 41944 42184 +240
- Partials 10010 10050 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e-strauss
approved these changes
Feb 16, 2026
Contributor
e-strauss
left a comment
e-strauss
left a comment
There was a problem hiding this comment.
lgtm, now you can read again the logs in the github actions without downloading them :)
| addTestConfiguration(dir, name); | ||
| getAndLoadTestConfiguration(name); | ||
|
|
||
| //run all mlcontext tests in loglevel trace to improve test coverage |
Contributor
There was a problem hiding this comment.
how would enabling the tracing, would help with code coverage anyways? is there conditional code on log level?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some PRs that fail on MLContextTests, and i saw they produce over 80k logging.
Therefore, to test my new setup, here is a PR that reduce this.