[MINOR] Upgrade Surefire to 3.5.2 and harden fork shutdown#2473
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2473 +/- ##
============================================
+ Coverage 71.37% 71.39% +0.01%
- Complexity 48749 48780 +31
============================================
Files 1571 1571
Lines 188912 188912
Branches 37067 37067
============================================
+ Hits 134845 134868 +23
+ Misses 43601 43595 -6
+ Partials 10466 10449 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fix intermittent ~26 minute hangs in the **.component.c**.** GitHub Actions job. The forks were finishing their test classes but failing to exit cleanly (leaked non-daemon threads from test executors), and Surefire 3.0.0 did not reliably enforce its fork shutdown timeout. - Bump maven-surefire-plugin from 3.0.0 to 3.5.2. - Set forkedProcessExitTimeoutInSeconds=30 so a fork that still has live threads after its test class completes is forcibly killed instead of stalling the run. - Set enableProcessChecker=native so each fork detects a dead parent and self-terminates, and Surefire can more reliably kill stuck forks on Linux. Verified across a full Java test matrix: component.c is stable, no job exceeds its 30 minute cap, and aggregate compute is unchanged.
Baunsgaard
force-pushed
the
fix-component-c-fork-hang
branch
from
1b65808 to
bc702e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes target the intermittent ~26 minute hangs between test classes seen in the
component.csuite.