[SYSTEMML-621] Remove redundant nested error messages#255
Closed
deroneriksson wants to merge 2 commits intoapache:masterfrom
Closed
[SYSTEMML-621] Remove redundant nested error messages#255deroneriksson wants to merge 2 commits intoapache:masterfrom
deroneriksson wants to merge 2 commits intoapache:masterfrom
Conversation
gweidner
reviewed
Sep 23, 2016
| // handle first parameter, which is data and may be unnamed | ||
| ParameterExpression firstParam = passedParamExprs.get(0); | ||
| if (firstParam.getName() != null && !firstParam.getName().equals(DataExpression.RAND_DATA)){ | ||
| // throw exception -- must be filename as first parameter |
Member
There was a problem hiding this comment.
Hi Deron - should this 'throw exception' comment also be removed similar to change made in line 278? Thanks, Glenn
Member
Author
There was a problem hiding this comment.
Good eye! Yes the comment should be removed too. I'll remove it.
Member
Author
|
Obsolete comment removed. |
Member
|
Thank you @deroneriksson for simplifying the error messages! LGTM |
Member
Author
|
@gweidner Thanks for reviewing! I'll merge. |
j143-zz
pushed a commit
to j143-zz/systemml
that referenced
this pull request
Nov 4, 2017
Remove some nested error messages for read, matrix, and rand statements. Closes apache#255.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses some redundant nested error messages for read, rand, and matrix statements.
Given the following DML:
This previously generated the following output:
With this PR it generates: