[SYSTEMML-1149] Remove unused constructors from project#315
Closed
deroneriksson wants to merge 2 commits intoapache:masterfrom
Closed
[SYSTEMML-1149] Remove unused constructors from project#315deroneriksson wants to merge 2 commits intoapache:masterfrom
deroneriksson wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
please be super careful about removing the copy constructors from the package org.apache.sysml.runtime as they are frequently used for debugging. |
Member
Author
|
Thank you for reviewing @mboehm7 and @dusenberrymw! I'll restore the copy constructors (in the package mentioned) and merge after that. |
Member
Author
|
All tests previously passed here: https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/914/ Restored runtime copy constructors. I'll merge. |
j143-zz
pushed a commit
to j143-zz/systemml
that referenced
this pull request
Nov 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unused constructors in the project are essentially dead code and make project maintenance more difficult. They should be removed unless there is a compelling reason to keep them.