Skip to content

Conversation

@sebwrede
Copy link
Contributor

@sebwrede sebwrede commented Jul 1, 2020

No description provided.

@sebwrede sebwrede marked this pull request as ready for review July 28, 2020 15:18
@mboehm7
Copy link
Contributor

mboehm7 commented Aug 8, 2020

LGTM - thanks for the patch @sebwrede. Sorry for the delay, I think it was about time to merge this in as the PR already started diverging from main. I resolved the conflicts, fixed some minor unnecessary imports, fixed the already changed federated L2SVM cmd parameters, and removed unnecessary uses of parallel streams (we try to avoid that for tiny collections because the performance impact is negative, and there is a danger of deadlocks if the surrounding code already uses the common fork-join pool). Furthermore, I reduce the datasizes in the tests such that the test time for the privacy package came down from 2500s to 170s on my laptop.

However, I also had to disable the L2SVM and individual operation tests as they were failing with privacy exceptions. Once you're back, let's look over them and see what changed are necessary wrt the rework of the federated backend.

@mboehm7
Copy link
Contributor

mboehm7 commented Aug 8, 2020

Also, I created the JIRA epic SYSTEMDS-2604 to keep track of all changes related to privacy constraints.

@asfgit asfgit closed this in 05c7dbc Aug 8, 2020
@sebwrede sebwrede deleted the FineGrainedPrivacy branch October 8, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants