This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-989: Cleanup of child blocks after parent execution block is comple...#103
Closed
jinossy wants to merge 3 commits intoapache:masterfrom
Closed
TAJO-989: Cleanup of child blocks after parent execution block is comple...#103jinossy wants to merge 3 commits intoapache:masterfrom
jinossy wants to merge 3 commits intoapache:masterfrom
Conversation
Member
There was a problem hiding this comment.
You can get the block id by calling block.getId(). So, cleanup() doesn't need to take an execution block id.
Member
|
+1 This work will remove unnecessary intermediate data earlier than the current implementation. The motivation is reasonable and the patch looks nice to me. I leaved one trivial comment. If you agree with my comment, you can commit it after refactoring SubQuery::cleanup method. |
Member
Author
|
Thank you for the review. I reflected your comments. |
babokim
pushed a commit
to babokim/tajo
that referenced
this pull request
Dec 11, 2014
…ksql Catching and displaying more error on SparkSql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...te