Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-895: ConstEval should not be included in target list of projectable...#111

Closed
hyunsik wants to merge 6 commits intoapache:masterfrom
hyunsik:TAJO-895
Closed

TAJO-895: ConstEval should not be included in target list of projectable...#111
hyunsik wants to merge 6 commits intoapache:masterfrom
hyunsik:TAJO-895

Conversation

@hyunsik
Copy link
Copy Markdown
Member

@hyunsik hyunsik commented Aug 8, 2014

... nodes.

hyunsik added 3 commits August 8, 2014 18:13
…into TAJO-895

Conflicts:
	tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java
	tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
	tajo-core/src/test/java/org/apache/tajo/cli/TestTajoCli.java
@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Aug 11, 2014

I've rebased it against the latest revision.

Could you anyone review this?

@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Aug 11, 2014

This has some bug for window function.

The reproduction query is as follows:

select l_orderkey, l_quantity, rank() over (partition by l_orderkey) as r, 5 as const_val from lineitem;

This problem is caused by handling const values in a window clause. I'll submit the patch soon, including the fix of the problem.

@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Aug 11, 2014

I've fixed the bug I mentioned.

@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Aug 13, 2014

This patch is conflict to TAJO-906. For next work, I need this work before TAJO-906. It would greatly appreciate if someone review this.

@jinossy
Copy link
Copy Markdown
Member

jinossy commented Aug 13, 2014

Sorry too late I'm reviewing

@jinossy
Copy link
Copy Markdown
Member

jinossy commented Aug 13, 2014

+1
Looks great to me. I've verified in real cluster

@asfgit asfgit closed this in 7e31a32 Aug 13, 2014
babokim pushed a commit to babokim/tajo that referenced this pull request Dec 11, 2014
…ctions

Group note action buttons together
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants