Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-931: Output file should be punctuated depending on the file size.#119

Closed
hyunsik wants to merge 16 commits into
apache:masterfrom
hyunsik:TAJO-931
Closed

TAJO-931: Output file should be punctuated depending on the file size.#119
hyunsik wants to merge 16 commits into
apache:masterfrom
hyunsik:TAJO-931

Conversation

@hyunsik
Copy link
Copy Markdown
Member

@hyunsik hyunsik commented Aug 16, 2014

No description provided.

hyunsik added 13 commits July 8, 2014 17:47
…into OUTPUT_ROTATING

Conflicts:
	tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
	tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
	tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
…into OUTPUT_ROTATING

Conflicts:
	tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashBasedColPartitionStoreExec.java
	tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortBasedColPartitionStoreExec.java
…into OUTPUT_ROTATING

Conflicts:
	tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
	tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
	tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortBasedColPartitionStoreExec.java
	tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java
	tajo-core/src/main/java/org/apache/tajo/engine/query/QueryContext.java
	tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
	tajo-core/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java
	tajo-storage/src/main/java/org/apache/tajo/storage/Appender.java
…into OUTPUT_ROTATING

Conflicts:
	tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
	tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
	tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortBasedColPartitionStoreExec.java
	tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java
	tajo-core/src/main/java/org/apache/tajo/engine/query/QueryContext.java
	tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
	tajo-core/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java
	tajo-storage/src/main/java/org/apache/tajo/storage/Appender.java
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to consider other null characters because of StorageConstants.SEQUENCEFILE_NULL and StorageConstants.RCFILE_NULL.

@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Aug 18, 2014

Hi @blrunner,

Thank you for your comment. I've reflected your comment and rebased it against the latest revision.

@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Aug 19, 2014

rebased.

@hyunsik hyunsik changed the title TAJO-931: Output file can be punctuated depending on the file size. TAJO-931: Output file should be punctuated depending on the file size. Aug 20, 2014
@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Aug 20, 2014

I've rebased, reflected the comments, and fixed some potential bugs. Please review this.

@blrunner
Copy link
Copy Markdown
Contributor

+1

It looks good overall and 'mvn clean install -Phcatalog-0.12.0 -Dtajo.catalog.store.class=org.apache.tajo.catalog.store.HCatalogStore' finished successfully.

@asfgit asfgit closed this in a1711d1 Aug 21, 2014
babokim pushed a commit to babokim/tajo that referenced this pull request Dec 11, 2014
fix not deleting notebook files when deleting notebook
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants