This repository was archived by the owner on May 12, 2021. It is now read-only.
Tajo 830: Some filter conditions with a SUBQUERY are removed by optimizer.#12
Closed
babokim wants to merge 4 commits into
Closed
Tajo 830: Some filter conditions with a SUBQUERY are removed by optimizer.#12babokim wants to merge 4 commits into
babokim wants to merge 4 commits into
Conversation
added 3 commits
May 21, 2014 02:30
Member
There was a problem hiding this comment.
Could you remove the korean comment?
…zer(remove the korean comment)
Member
|
+1 The patch looks good to me. There are only a few of trivial things to be fixed. Since they are very trivial, I just fixed them. For example, I removed some commented out line including your name, and I add more comments in several methods. I'll commit it shortly. |
babokim
pushed a commit
to babokim/tajo
that referenced
this pull request
Dec 11, 2014
…LIN-69 Add Bruch.io to mvn build process for zeppein-web
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I refactored FilterPushDownRule.
FilterPushDown rule
processing when visits each node
- If a target which is corresponding on a filter EvalNode's column is not FieldEval, do not PushDown.
- Replace filter EvalNode's column with child node's output column.
If there is no child node's output column, do not PushDown.
- When visit ScanNode, add filter eval to ScanNode's qual
- When visit GroupByNode, Find aggregation column in a filter EvalNode and
. If a parent is HavingNode, add filter eval to parent HavingNode.
. It not, create new HavingNode and set parent's child.