Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1022: tsql does not work as background process#128

Closed
babokim wants to merge 4 commits intoapache:masterfrom
babokim:TAJO-1022
Closed

TAJO-1022: tsql does not work as background process#128
babokim wants to merge 4 commits intoapache:masterfrom
babokim:TAJO-1022

Conversation

@babokim
Copy link
Copy Markdown
Contributor

@babokim babokim commented Aug 31, 2014

No description provided.

@jihoonson
Copy link
Copy Markdown
Contributor

+1
Great!

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Sep 2, 2014

When this patch is applied, the arrow and esc keys does not work anymore. As a temporary solution, we can add some option for non-interactive mode for background job. How do you think?

@babokim
Copy link
Copy Markdown
Contributor Author

babokim commented Sep 2, 2014

Nice catch hyunsik. I did't realize that problem.
I found that hive shell have same problem. See the following site.
https://issues.apache.org/jira/browse/HIVE-6758
Hive does not support "jline.UnsupportedTerminal" option, but documented a workaround.

In my opinion many tajo query will be run as background mode, so background mode option is good to user.
What do you think about "-B" as background mode option like the bellow.

"bin/tsql -B -t test.sql &"

@babokim
Copy link
Copy Markdown
Contributor Author

babokim commented Sep 5, 2014

I pushed new patch. I added "-B" option for running CLI as background. This is a temporal solution. If you find a better way this patch should be replaced.

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Sep 10, 2014

It needs rebase. Also, I have one suggestion. We have used lower case characters as options. Like -B, -b also can indicate background. Do you have any reason using upper case?

@babokim
Copy link
Copy Markdown
Contributor Author

babokim commented Sep 11, 2014

There is no special reason. I thought that this mode is not a typical mode so I used 'B' instead of 'b'.

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Sep 11, 2014

+1

Ship it.

@asfgit asfgit closed this in 604eb32 Sep 11, 2014
babokim pushed a commit to babokim/tajo that referenced this pull request Dec 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants