This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-948: 'INSERT INTO' statement to non existence table casuses NPE#142
Closed
eminency wants to merge 2 commits into
Closed
TAJO-948: 'INSERT INTO' statement to non existence table casuses NPE#142eminency wants to merge 2 commits into
eminency wants to merge 2 commits into
Conversation
eminency
changed the title
Member
There was a problem hiding this comment.
The bug fix looks correct. But, I have one suggestion about the message. The other similar cases use relation "%s" does not exist. Could you change the message for consistency?
You can see the similar case at https://github.com/eminency/tajo/blob/TAJO-948/tajo-core/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java#L134
Contributor
Author
|
@hyunsik , Your line comment sounds like a good suggestion. Thanks. |
Contributor
Author
|
The message was refined. |
Member
|
+1 The patch looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cause is there is no part to check if the table instance is null before it's used.
Please review if the changeset is appropriate.
Thanks.