Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1068: Add SQL Query documentation.#155

Closed
hyunsik wants to merge 4 commits intoapache:masterfrom
hyunsik:TAJO-1068
Closed

TAJO-1068: Add SQL Query documentation.#155
hyunsik wants to merge 4 commits intoapache:masterfrom
hyunsik:TAJO-1068

Conversation

@hyunsik
Copy link
Copy Markdown
Member

@hyunsik hyunsik commented Sep 24, 2014

No description provided.

@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Sep 26, 2014

I've updated the explanation of the groupby clause. Could you anyone review this?

@mhthanh
Copy link
Copy Markdown

mhthanh commented Sep 26, 2014

If nobody reviews your doc in the weekend, I will review it next Monday ;-)

@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Sep 26, 2014

@mhthanh Thanks a lot!

@mhthanh
Copy link
Copy Markdown

mhthanh commented Sep 29, 2014

Overall, the patch looks good to me and I think that it will be useful for Tajo users.
Besides, there are a few typos (all in "queries.rst") as follows.

  • Line 37: "Aliase" -> "Aliases"
  • Line 57: "a long table references" -> "long table references"
  • Line 79: "Catesian product" -> "Cartesian product"
  • Line 193: "an descending order" -> "a descending order"
  • Line 240: "any expressions and aggregation functions are allowed in ORDER BY clause" -> this makes me confused. Does it mean "all expressions and aggregation functions are allowed in ORDER BY clause" ?

@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Sep 30, 2014

Hi @mhthanh,

I greatly appreciate your review and contributions. Thank you for fixing the errors. I'll reflect all your comments.

You are right for Line 240. I'll fix it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aliases ?

@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Oct 1, 2014

Hi @mhthanh and @hsaputra,

Thank you all for your revision. I reflected your comments and updated the patch.

@hsaputra
Copy link
Copy Markdown
Contributor

hsaputra commented Oct 2, 2014

+1 LGTM

@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Oct 2, 2014

Thank you @hsaputra for the quick review! I'll commit it shortly.

@asfgit asfgit closed this in 2d4b084 Oct 2, 2014
@hyunsik hyunsik deleted the TAJO-1068 branch October 2, 2014 00:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants