Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

Tajo-668: Add datetime function documentation#160

Closed
eminency wants to merge 2 commits intoapache:masterfrom
eminency:TAJO-668_datetime_func_doc
Closed

Tajo-668: Add datetime function documentation#160
eminency wants to merge 2 commits intoapache:masterfrom
eminency:TAJO-668_datetime_func_doc

Conversation

@eminency
Copy link
Copy Markdown
Contributor

Like a kind of first draft...

Review in depth. It's much and rough.

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Sep 25, 2014

Your patch includes some of Postgresql documentation. We already noticed that Tajo includes PostgreSQL. The license of PostgreSQL is compatible with ASF 2.0. In my view, the documentation looks good to me.

You said the documentation is rough. Could you let me know what parts do you want us to review intensively?

@eminency
Copy link
Copy Markdown
Contributor Author

@hyunsik ,

Especially it means last part about conversion and formatting.

Like you said, it is almost quoted from PostgresSQL documentation. But I couldn't test for all features though I tested other basic examples. So I couldn't guarantee documentation contents because I don't have full knowledge of tajo datetime function implementation.

If there is no difference in actual datetime implementation between Tajo and Pgsql, I think it may be OK that you glance it.

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Oct 2, 2014

For date/time conversion and formatting, we ported pgsql's implementation to Tajo. So, most of all features are compatible between Tajo and pgsql. So, it would be Ok.

@babokim could you look over this documentation? Because you contributed this feature, you may be the best reviewer on this issue.

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Oct 5, 2014

+1 I'll commit it soon.

If we find something to be revise later, we can make additional jira and patch at that time.

@asfgit asfgit closed this in ecc2b05 Oct 5, 2014
@eminency eminency deleted the TAJO-668_datetime_func_doc branch October 6, 2014 08:52
babokim pushed a commit to babokim/tajo that referenced this pull request Dec 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants