Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1084: Generated classes should access directly UnSafeTuple and RowWriter.#171

Closed
hyunsik wants to merge 6 commits intoapache:block_iterationfrom
hyunsik:TAJO-1084
Closed

TAJO-1084: Generated classes should access directly UnSafeTuple and RowWriter.#171
hyunsik wants to merge 6 commits intoapache:block_iterationfrom
hyunsik:TAJO-1084

Conversation

@hyunsik
Copy link
Copy Markdown
Member

@hyunsik hyunsik commented Sep 29, 2014

This patches depends TAJO-1042, TAJO-1043, TAJO-1080, and TAJO-1083. So, it includes all patches of them.

@jinossy
Copy link
Copy Markdown
Member

jinossy commented Oct 1, 2014

@hyunsik
Could you update the HeapTupleBytesComparator.java with JDK 1.6 ?

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project tajo-storage: Compilation failure: Compilation failure:
[ERROR] /Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[42,47] cannot find symbol
[ERROR] symbol  : variable ARRAY_BYTE_BASE_OFFSET
[ERROR] location: class sun.misc.Unsafe
[ERROR] /Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[42,24] cannot find symbol
[ERROR] symbol  : method getInt(byte[],<nulltype>)
[ERROR] location: class sun.misc.Unsafe
[ERROR] /Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[43,47] cannot find symbol
[ERROR] symbol  : variable ARRAY_BYTE_BASE_OFFSET
[ERROR] location: class sun.misc.Unsafe
[ERROR] /Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[43,24] cannot find symbol
[ERROR] symbol  : method getInt(byte[],<nulltype>)
[ERROR] location: class sun.misc.Unsafe
[ERROR] /Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[57,46] cannot find symbol
[ERROR] symbol  : variable ARRAY_BYTE_BASE_OFFSET
[ERROR] location: class sun.misc.Unsafe
[ERROR] /Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[57,22] cannot find symbol
[ERROR] symbol  : method getLong(byte[],<nulltype>)
[ERROR] location: class sun.misc.Unsafe
[ERROR] /Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[58,46] cannot find symbol
[ERROR] symbol  : variable ARRAY_BYTE_BASE_OFFSET
[ERROR] location: class sun.misc.Unsafe
[ERROR] /Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[58,22] cannot find symbol
[ERROR] symbol  : method getLong(byte[],<nulltype>)
[ERROR] location: class sun.misc.Unsafe
[ERROR] /Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[95,49] cannot find symbol
[ERROR] symbol  : variable ARRAY_BYTE_BASE_OFFSET
[ERROR] location: class sun.misc.Unsafe
[ERROR] /Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[95,25] cannot find symbol
[ERROR] symbol  : method getByte(byte[],<nulltype>)
[ERROR] location: class sun.misc.Unsafe
[ERROR] /Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[96,40] cannot find symbol
[ERROR] symbol  : variable ARRAY_BYTE_BASE_OFFSET
[ERROR] location: class sun.misc.Unsafe
[ERROR] /Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[96,16] cannot find symbol
[ERROR] symbol  : method getByte(byte[],<nulltype>)
[ERROR] location: class sun.misc.Unsafe

@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Oct 1, 2014

I removed the direct use of UnSafe's offsets, causing compilation error in Java 6.

@jinossy
Copy link
Copy Markdown
Member

jinossy commented Oct 1, 2014

+1
Thank you for your quick fix

asfgit pushed a commit that referenced this pull request Oct 1, 2014
@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Oct 1, 2014

committed.

1 similar comment
@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Oct 1, 2014

committed.

@hyunsik hyunsik closed this Oct 1, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants