TAJO-1026: Implement Query history persistency manager.#179
TAJO-1026: Implement Query history persistency manager.#179babokim wants to merge 13 commits intoapache:masterfrom
Conversation
Completed Writer
…into TAJO-1026
Fixed the problem HistoryReader uses current time finding QueryHistory.
Fixed NPE when there is no history directory.
…into TAJO-1026
|
I'm sorry for late review. Could you rebase it against the latest revision? Actually, I'm already reviewing it after trivial rebase. But it is better for you to push the rebased version because github pull request (PR) does not allow some user to push to another user's PR. |
…into TAJO-1026 Conflicts: tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
|
I'm sorry for late rebase. I just rebase. |
There was a problem hiding this comment.
I'd like to suggest using tajo.history prefix for query and task histories. It seems to be more consistency. Also, we already use -expiry-time-[unit] suffix for expiry time. So, I'd like to suggest the followings:
tajo.history.query.dirtajo.history.task.dirtajo.history.expiry-time-day
There was a problem hiding this comment.
It looks better. I will modify it as your comment.
|
Hi @babokim, It's really great work. This work will reduce our memory consumption for keeping history in memory, and this work is able to keep history longer than now. I leave some comments and some questions. After your feedback, I'll finish the review. |
Changes history related property name.
…into TAJO-1026
Fixed NPE in querytasks.jsp
|
+1 The patch looks nice to me. I checked the history list and task details in web UI. They work well. |
|
@hyunsik Thanks. I had just committed. |
Newly created note can not load looknfeel after first run, until user manually change looknfeel
Query history has the three types of files.
<tajo.query-history.path>/<yyyyMMdd>/query-list/query-list-<sequence>.hist<tajo.query-history.path>/<yyyyMMdd>/query-detail/<QUERY_ID>/query.hist<tajo.query-history.path>/<yyyyMMdd>/query-detail/<QUERY_ID>/<EB_ID>.histTask detail file: saving the task history(default is local), stored by Worker.
<tajo.task-history.path>/<yyyyMMdd>/tasks/<WORKER_HOST>_<WORKER_PORT>/<WORKER_HOST>_<WORKER_PORT>_<HH>_<seq>.histAnd I added page navigation in query.jsp and querytasks.jsp