Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1026: Implement Query history persistency manager.#179

Closed
babokim wants to merge 13 commits intoapache:masterfrom
babokim:TAJO-1026
Closed

TAJO-1026: Implement Query history persistency manager.#179
babokim wants to merge 13 commits intoapache:masterfrom
babokim:TAJO-1026

Conversation

@babokim
Copy link
Copy Markdown
Contributor

@babokim babokim commented Oct 5, 2014

Query history has the three types of files.

  • Query list file: saving the list of query(default store is hdfs), hourly rolling, stored by TajoMaster.

<tajo.query-history.path>/<yyyyMMdd>/query-list/query-list-<sequence>.hist

  • Query detail file: saving the query plan and execution block summary(default store is hdfs), single file per query or execution block, stored by QueryMaster.

<tajo.query-history.path>/<yyyyMMdd>/query-detail/<QUERY_ID>/query.hist

<tajo.query-history.path>/<yyyyMMdd>/query-detail/<QUERY_ID>/<EB_ID>.hist

  • Task detail file: saving the task history(default is local), stored by Worker.

    <tajo.task-history.path>/<yyyyMMdd>/tasks/<WORKER_HOST>_<WORKER_PORT>/<WORKER_HOST>_<WORKER_PORT>_<HH>_<seq>.hist

And I added page navigation in query.jsp and querytasks.jsp

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Oct 25, 2014

I'm sorry for late review. Could you rebase it against the latest revision?

Actually, I'm already reviewing it after trivial rebase. But it is better for you to push the rebased version because github pull request (PR) does not allow some user to push to another user's PR.

HyoungJun Kim added 2 commits November 6, 2014 14:25
…into TAJO-1026

Conflicts:
	tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java
	tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
	tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
	tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
@babokim
Copy link
Copy Markdown
Contributor Author

babokim commented Nov 6, 2014

I'm sorry for late rebase. I just rebase.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to suggest using tajo.history prefix for query and task histories. It seems to be more consistency. Also, we already use -expiry-time-[unit] suffix for expiry time. So, I'd like to suggest the followings:

  • tajo.history.query.dir
  • tajo.history.task.dir
  • tajo.history.expiry-time-day

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks better. I will modify it as your comment.

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Nov 10, 2014

Hi @babokim,

It's really great work. This work will reduce our memory consumption for keeping history in memory, and this work is able to keep history longer than now.

I leave some comments and some questions. After your feedback, I'll finish the review.

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Nov 10, 2014

+1

The patch looks nice to me. I checked the history list and task details in web UI. They work well.

@babokim
Copy link
Copy Markdown
Contributor Author

babokim commented Nov 11, 2014

@hyunsik Thanks. I had just committed.

@asfgit asfgit closed this in e01b00a Nov 11, 2014
babokim pushed a commit to babokim/tajo that referenced this pull request Dec 11, 2014
Newly created note can not load looknfeel after first run, until user manually change looknfeel
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants