Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-844: JDBC should be support getTime, getDate, getTimestamp#19

Closed
babokim wants to merge 4 commits into
apache:masterfrom
babokim:TAJO-844
Closed

TAJO-844: JDBC should be support getTime, getDate, getTimestamp#19
babokim wants to merge 4 commits into
apache:masterfrom
babokim:TAJO-844

Conversation

@babokim
Copy link
Copy Markdown
Contributor

@babokim babokim commented May 26, 2014

No description provided.

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Jun 5, 2014

My timezone is PDT. There is no TZ environment. In this environment, I faced some unit test failure as follows:

Result:

Results :

Failed tests:   testSortWithDate(org.apache.tajo.engine.query.TestSortQuery): Result Verification expected:<...(..)

expected:

col1,col2,col3
-------------------------------
1993-11-09 20:34:56.0,1997-01-28,08:34:56
1995-11-09 20:34:56.0,1993-11-09,20:34:56
1995-11-09 20:34:56.0,1994-02-02,17:34:56
1997-11-09 20:34:56.0,1996-03-13,19:34:56
1997-11-09 20:34:56.0,1996-04-12,15:34:56

Actual:

col1,col2,col3
-------------------------------
1993-11-09 20:34:56,1997-01-28,08:34:56
1995-11-09 20:34:56,1993-11-09,20:34:56
1995-11-09 20:34:56,1994-02-02,17:34:56
1997-11-09 20:34:56,1996-03-13,19:34:56
1997-11-09 20:34:56,1996-04-12,15:34:56

김형준 added 2 commits June 10, 2014 21:39
@babokim
Copy link
Copy Markdown
Contributor Author

babokim commented Jun 10, 2014

Removed ".0" from result file from test resources.

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Jun 11, 2014

+1

The patch looks good to me. Thank you for your contribution.

@asfgit asfgit closed this in 06be060 Jun 11, 2014
babokim pushed a commit to babokim/tajo that referenced this pull request Dec 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants