TAJO-1119: JDBC driver should support TIMESTAMP type.

[blrunner]

TAJO-1119: JDBC driver should support TIMESTAMP type.

[hyunsik]

The patch looks good to me.

But, this patch seems to omit the test to retrieve values. Could you add more unit tests to get timestamp values from JDBC ResultSet?

[hyunsik]

Hi @blrunner,

I think this fix should be included in 0.9.1. How do you think about that?

[blrunner]

Hi @hyunsik

NP... I'll add more unit test cases by tomorrow night. :)

[blrunner]

Hi @hyunsik

I added a unit test case to verify ResultSet.
Could you check the patch again?

[hyunsik]

TravisCI causes the following error. Could you check it? or could you submit the patch to jira and trigger the jenkins unit test?

Results :
Failed tests: 
  TestJoinQuery.testOuterJoinAndCaseWhen1:314->QueryTestCaseBase.executeDDL:544->QueryTestCaseBase.executeDDL:572 Table [table1] creation is failed.
  TestJoinQuery.testOuterJoinAndCaseWhen1:314->QueryTestCaseBase.executeDDL:544->QueryTestCaseBase.executeDDL:572 Table [table1] creation is failed.
  TestJoinQuery.testOuterJoinAndCaseWhen1:314->QueryTestCaseBase.executeDDL:544->QueryTestCaseBase.executeDDL:572 Table [table1] creation is failed.
  TestJoinQuery.testOuterJoinAndCaseWhen1:314->QueryTestCaseBase.executeDDL:544->QueryTestCaseBase.executeDDL:572 Table [table1] creation is failed.
  TestSortQuery.testSortWithDate:134->QueryTestCaseBase.executeDDL:544->QueryTestCaseBase.executeDDL:572 Table [table1] creation is failed.
Tests in error: 
  TestGroupByQuery.testGroupByWithNullData5:586->QueryTestCaseBase.executeString:293 » Service
  TestGroupByQuery.testGroupByWithNullData6:598->QueryTestCaseBase.executeString:293 » Service
  TestGroupByQuery.testGroupByWithNullData7:610->QueryTestCaseBase.executeString:293 » Service
  TestGroupByQuery.testGroupByWithNullData8:622->QueryTestCaseBase.executeString:293 » Service
  TestGroupByQuery.testGroupByWithNullData9:634->QueryTestCaseBase.executeString:293 » Service
  TestGroupByQuery.testGroupByWithNullData5:586->QueryTestCaseBase.executeString:293 » Service
  TestGroupByQuery.testGroupByWithNullData6:598->QueryTestCaseBase.executeString:293 » Service
  TestGroupByQuery.testGroupByWithNullData7:610->QueryTestCaseBase.executeString:293 » Service
  TestGroupByQuery.testGroupByWithNullData8:622->QueryTestCaseBase.executeString:293 » Service
  TestGroupByQuery.testGroupByWithNullData9:634->QueryTestCaseBase.executeString:293 » Service
  TestJoinBroadcast.testLeftOuterJoinLeftSideSmallTable:590 » Service java.sql.S...

[blrunner]

Hi @hyunsik

I fixed a bug. The Travis CI build will build successfully tonight.

[hyunsik]

Thank you for your contribution. I'll review the patch soon.

[hyunsik]

+1

Ship it. The patch looks good to me.

[blrunner]

Thanks @hyunsik.
I've just committed it to master branch.