This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1126: Join condition including functions throws IllegalArgumentExce...#209
Closed
hyunsik wants to merge 1 commit into
Closed
TAJO-1126: Join condition including functions throws IllegalArgumentExce...#209hyunsik wants to merge 1 commit into
hyunsik wants to merge 1 commit into
Conversation
Member
Author
|
rebased. |
Member
|
+1 Looks great to me. |
babokim
pushed a commit
to babokim/tajo
that referenced
this pull request
Dec 11, 2014
Fix/Improve daemon script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...ption.
See https://issues.apache.org/jira/browse/TAJO-1126.
Thank you for enclosing the reproducible query and detailed bug reports.
In addition to above description, I discussed this problem with Hyoungjun in offline chat. He informed me the bug where the parameterized unit tests in TestJoin does not work. The fact that QueryUnitRequesttImpl newly creates TajoConf instance instead of taking existing TajoConf causes this bug. So, given parameters were lost during unit tests. This problem is hiding the unit test failures. As he mentioned, I could find about 20 test failures in TestJoin when I fixed this parameters loss problem.
I found the bug from PlannerUtil::isJoinQual. I improved this method to take two schemas of both relations for join, and I also enabled the method to ensure by checking schemas if both expressions composes a join condition. As a result, all the failures in TestJoin are passed.