Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-699: Create a table using LIKE#21

Closed
prafullat wants to merge 2 commits into
apache:masterfrom
prafullat:tajo-699
Closed

TAJO-699: Create a table using LIKE#21
prafullat wants to merge 2 commits into
apache:masterfrom
prafullat:tajo-699

Conversation

@prafullat
Copy link
Copy Markdown

This commit implements following DDL in Tajo.
create table <table_name> like <existing_table_name>;

This commit implements following DDL in Tajo.
create table <table_name> like <existing_table_name>;
@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented May 26, 2014

Thank you for contribution.

I've just briefly reviewed your patch. The patch looks nice and includes sufficient unit tests. Actually, now I'd like to check more cases using your 'CREATE TABLE LIKE', but here is already 4:30 AM. So, I'll review your patch tomorrow, and I'll comment soon!

Thanks!

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented May 27, 2014

Hi Prafulla,

I reviewed your patch in more detail. Excellent! You work is very nice. It works well. I leave only some trivial comments.

Although we do not use maven checkstyle plugin to strictly check coding convention, we already use some coding style. Please take a look at this [1]. We use 2 space instead of tab. Other conventions you use look nice to me.

In addition, it would be better if you use assertTrue(message : string, condition:boolean) and assertEquals(message : string, obj1:Object, obj2:Object) instead of using System.out.println in isClonedSchema. It usually generates more comprehensive output messages in the tail of maven message when the test is failed.

Replaced tabs with spaces at few places.
Replaced assertEquals
@prafullat
Copy link
Copy Markdown
Author

Thanks for comments.
I have implemented review comments in latest commit in this pull request.
Should I also update it on Jira?

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented May 27, 2014

I think that updating github pull request is enough for us. I'll review your latest change. Thank you!

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented May 27, 2014

+1

The latest patch looks good to me. I'll commit it shortly. Thank you for your contribution!

@asfgit asfgit closed this in a191b1d May 27, 2014
babokim pushed a commit to babokim/tajo that referenced this pull request Dec 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants