TAJO-699: Create a table using LIKE#21
Conversation
This commit implements following DDL in Tajo. create table <table_name> like <existing_table_name>;
|
Thank you for contribution. I've just briefly reviewed your patch. The patch looks nice and includes sufficient unit tests. Actually, now I'd like to check more cases using your 'CREATE TABLE LIKE', but here is already 4:30 AM. So, I'll review your patch tomorrow, and I'll comment soon! Thanks! |
|
Hi Prafulla, I reviewed your patch in more detail. Excellent! You work is very nice. It works well. I leave only some trivial comments. Although we do not use maven checkstyle plugin to strictly check coding convention, we already use some coding style. Please take a look at this [1]. We use 2 space instead of tab. Other conventions you use look nice to me. In addition, it would be better if you use |
Replaced tabs with spaces at few places. Replaced assertEquals
|
Thanks for comments. |
|
I think that updating github pull request is enough for us. I'll review your latest change. Thank you! |
|
+1 The latest patch looks good to me. I'll commit it shortly. Thank you for your contribution! |
Zeppelin archive network
This commit implements following DDL in Tajo.
create table <table_name> like <existing_table_name>;