Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-850: OUTER JOIN does not properly handle a NULL.#22

Closed
babokim wants to merge 12 commits into
apache:masterfrom
babokim:TAJO-850
Closed

TAJO-850: OUTER JOIN does not properly handle a NULL.#22
babokim wants to merge 12 commits into
apache:masterfrom
babokim:TAJO-850

Conversation

@babokim
Copy link
Copy Markdown
Contributor

@babokim babokim commented May 27, 2014

No description provided.

김형준 added 7 commits May 21, 2014 02:30
Conflicts:
	tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
Conflicts:
	tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java
	tajo-core/src/main/java/org/apache/tajo/engine/planner/logical/GroupbyNode.java
	tajo-core/src/main/java/org/apache/tajo/engine/planner/rewrite/FilterPushDownRule.java
@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented May 27, 2014

This is conflict to the latest revision. Could you rebase it?

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Jun 24, 2014

+1

Although the unit test seems to be failed, the failure is caused by the long log message. Travis causes failure if the log size > 4MB.

I verified 'mvn clean install'. The patch fixes outer join condition bugs and includes enough unit tests to verify the bug fix.

In addition, I revised some trivial things as follows:

  • Remove unnecessary plan log in GlobalEngine.java
  • Remove commented out lines in TajoTestingCluster and ProjectionPushDownRule
  • Rename EvalTreeUtil::findOuterJoinConditionEvals to EvalTreeUtil::findOuterJoinSensitiveEvals because they are subexpressions of join condition.

I'll commit it shortly. Thank you for your great contribution!

@asfgit asfgit closed this in be21bc7 Jun 24, 2014
babokim pushed a commit to babokim/tajo that referenced this pull request Dec 11, 2014
…re_predictable

Fixing ZQLSessionManagerTest failure
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants