Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-854: Supports INSERT INTO with UNION#24

Closed
babokim wants to merge 4 commits intoapache:masterfrom
babokim:TAJO-854
Closed

TAJO-854: Supports INSERT INTO with UNION#24
babokim wants to merge 4 commits intoapache:masterfrom
babokim:TAJO-854

Conversation

@babokim
Copy link
Copy Markdown
Contributor

@babokim babokim commented May 28, 2014

No description provided.

jihoonson
jihoonson reviewed Jun 1, 2014
View reviewed changes
Comment thread tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
Copy link
Copy Markdown
Contributor

@jihoonson jihoonson Jun 1, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a question. When doesn't InputSchema contain all columns of OutSchema?

Copy link
Copy Markdown
Contributor Author

@babokim babokim Jun 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That case is also fine. Because we need a SubQueryNode which contains all columns in InputSchema matched with Target and OutputSchema's column.

@jihoonson
Copy link
Copy Markdown
Contributor

jihoonson commented Jun 1, 2014

Hi Hyoungjun,
thanks for your contribution.
The patch looks good, and I left some minor comments.
Thanks!

@jihoonson
Copy link
Copy Markdown
Contributor

jihoonson commented Jun 2, 2014

+1
Thanks, Hyoungjun!

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Jun 5, 2014

@jihoonson
Could I commit this? Before committing it, I'd like to add more comments. If you guys are Ok, I'll do.

@jihoonson
Copy link
Copy Markdown
Contributor

jihoonson commented Jun 6, 2014

@hyunsik sorry. I forget committing the patch.
Please go ahead.

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Jun 6, 2014

It was already committed. Since this is not close, I misunderstood. I'm sorry for confusing. In order to close github issue, you should add 'Closes #24' to the commit message.

You can see the description in each jira issue as follows:
https://issues.apache.org/jira/browse/TAJO-854?focusedCommentId=14011082&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14011082

asfgit pushed a commit that referenced this pull request Jun 6, 2014
@hyunsik
TAJO-860: Implements TRUNCATE table. (missed github closes)
ace1d47 
Closes #29, #24.
@jihoonson
Copy link
Copy Markdown
Contributor

jihoonson commented Jun 7, 2014

Right.. Even though I committed it, I forgot..
Thanks.

@asfgit asfgit closed this in 4feb537 Jun 11, 2014
babokim pushed a commit to babokim/tajo that referenced this pull request Dec 11, 2014
Merge pull request apache#24 from NFLabs/build_without_nodejs_externa…
4ba9f83 
…l_dependency

Switching web-app build to embed node.js dependency in maven
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@babokim @jihoonson @hyunsik