TAJO-1221: HA TajoClient should not connect TajoMaster at the first.#286
TAJO-1221: HA TajoClient should not connect TajoMaster at the first.#286blrunner wants to merge 21 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Main components (ex: CatalogServer, TajoResourceTracker) create an InetSocketAddress with NetUtils::createSocketAddr and TajoConf. But if the address set to "0.0.0.0" at TajoConf, NetUtils::createSocketAddr bind socket address to "localhost" unconditionally. It does matter on Yarn with TajoMaster Ha. If socket address bind to "localohost" in Netty, TajoWorker never can't connect the component. So, I set local ip address with NetUtils::createLocalSocketAddr. If you have any good idea, suggest to me easefully.
|
Thanks @hyunsik. I've just added a constant class for HA. And I leaved some comments for NetUtils::createLocalSocketAddr. |
|
You seem to merge your patch with wrong revisions. Could you check the submitted patch? |
…into TAJO-1221
|
Thanks @hyunsik I merged the master branch to TAJO-1221 again. |
|
Hi @hyunsik. I removed NetUtils::createLocalSocketAddr. And we need to guide for users to use rpc server address '0.0.0.0' instead of 'localhost' on yarn cluster. |
…into TAJO-1221
…into TAJO-1221 Conflicts: tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMaster.java
There was a problem hiding this comment.
The port is hard coded. any have reason ?
|
Thanks @jinossy , |
…into TAJO-1221
|
+1 |
3 participants
I added a method to update TableStats at CatalogStore. For reference, all unit cases for physical operators verify output row numbers and it finished successfully with my patch. So, I didn't implement unit test cases. In addition, HCatalogStore::updateTableStats is dummy method. Because hive don't provide no api to update table row numbers.