Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

Tajo-1258: Close() for classes derived from FileAppender should consider inited state#309

Closed
eminency wants to merge 2 commits into
apache:masterfrom
eminency:TAJO-1258
Closed

Tajo-1258: Close() for classes derived from FileAppender should consider inited state#309
eminency wants to merge 2 commits into
apache:masterfrom
eminency:TAJO-1258

Conversation

@eminency
Copy link
Copy Markdown
Contributor

Close() for FileAppender is added and derived classes use it to check initialization state.

This modification is also including resolution for TAJO-1227.

@eminency eminency changed the title Tajo-1258: Close() derived FileAppender should consider inited state Tajo-1258: Close() for classes derived from FileAppender should consider inited state Dec 18, 2014
@jinossy
Copy link
Copy Markdown
Member

jinossy commented Dec 29, 2014

@eminency Thank you for your contribution
File or stream or buffer should close, if these open.
In my opinion, we just need to add safety closing. such as IOUtils.cleanup

@eminency
Copy link
Copy Markdown
Contributor Author

Thank you for suggestion, @jinossy .

It looks like smarter way.

I will study and work on it.

@eminency eminency closed this Jan 8, 2015
@eminency eminency deleted the TAJO-1258 branch January 8, 2015 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants