TAJO-1265: min(), max() does not handle null properly#315
TAJO-1265: min(), max() does not handle null properly#315sirpkt wants to merge 11 commits intoapache:masterfrom
Conversation
|
This patch seems to not pass 'mvn clean install'. |
|
@hyunsik Sorry for the incomplete patch. |
|
I updated the patch as followings
mvn clean install passed. sum() and avg() also need to be changed to handle null differently from non-null values. |
Test cases for sum() and avg() are modified also.
|
I also modified sum() and avg() to handle null properly. |
|
I'll review it tonight. Thank you for your contribution. |
|
The patch looks good to me. It corrects the wrong implementation. There are some trivial things that I need to check. I'll finish the review by tomorrow. |
|
+1 |
|
Hi @sirpkt, I leave some trivial comments. Because they are trivial, you can commit after you remove them. |
|
Thank you for the review, @hyunsik. |
|
I just committed the patch. |
min() and max() handle null value separately from non-null values.
It computes min() or max() among non-null values first.
If no non-null value exists, they return null value.
Implementation style of min() and max() is also changed that
there are abstract classes of Min and Max common for all the data types
and only type specific methods are implemented for each type.