Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1228: TajoClient should communicate with only TajoMaster without TajoWorker.#317

Closed
hyunsik wants to merge 11 commits intoapache:masterfrom
hyunsik:TAJO-1228
Closed

TAJO-1228: TajoClient should communicate with only TajoMaster without TajoWorker.#317
hyunsik wants to merge 11 commits intoapache:masterfrom
hyunsik:TAJO-1228

Conversation

@hyunsik
Copy link
Copy Markdown
Member

@hyunsik hyunsik commented Dec 24, 2014

@blrunner
Copy link
Copy Markdown
Contributor

Hi @hyunsik

Could you rebase sources against the apache master branch?
I can't merge as follows:
Auto-merging tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
CONFLICT (content): Merge conflict in tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
Auto-merging tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
Automatic merge failed; fix conflicts and then commit the result.

@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Dec 26, 2014

I've rebased it. Thanks!

@blrunner
Copy link
Copy Markdown
Contributor

Thanks @hyunsik, I merged the patch successfully. I'll start to review it. :)

@blrunner
Copy link
Copy Markdown
Contributor

Hi @hyunsik

If possible, could you check the patch on testing cluster?
I failed Q3 query on tpc-h benchmark dataset with the patch as follows:

2014-12-27 01:18:08,273 ERROR org.apache.tajo.catalog.CatalogServer: java.lang.NullPointerException
2014-12-27 01:18:08,273 ERROR org.apache.tajo.catalog.AbstractCatalogClient: com.google.protobuf.ServiceException: java.lang.NullPointerException
com.google.protobuf.ServiceException: com.google.protobuf.ServiceException: java.lang.NullPointerException
at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:105)
at org.apache.tajo.catalog.AbstractCatalogClient.getTableDesc(AbstractCatalogClient.java:243)
at org.apache.tajo.catalog.AbstractCatalogClient.getTableDesc(AbstractCatalogClient.java:262)
at org.apache.tajo.plan.LogicalPlanPreprocessor.visitRelation(LogicalPlanPreprocessor.java:385)
at org.apache.tajo.plan.LogicalPlanPreprocessor.visitRelation(LogicalPlanPreprocessor.java:44)
at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visit(BaseAlgebraVisitor.java:98)
at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visitRelationList(BaseAlgebraVisitor.java:418)
at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visit(BaseAlgebraVisitor.java:95)
at org.apache.tajo.plan.LogicalPlanPreprocessor.visitProjection(LogicalPlanPreprocessor.java:197)
at org.apache.tajo.plan.LogicalPlanPreprocessor.visitProjection(LogicalPlanPreprocessor.java:44)
at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visit(BaseAlgebraVisitor.java:59)
at org.apache.tajo.plan.LogicalPlanner.createPlan(LogicalPlanner.java:141)
at org.apache.tajo.plan.LogicalPlanner.createPlan(LogicalPlanner.java:131)
at org.apache.tajo.master.GlobalEngine.createLogicalPlan(GlobalEngine.java:232)
at org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:161)
at org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:284)
at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:543)
at org.apache.tajo.rpc.BlockingRpcServer$ServerHandler.messageReceived(BlockingRpcServer.java:103)

@blrunner
Copy link
Copy Markdown
Contributor

blrunner commented Jan 5, 2015

+1

I tested the patch on tpc-h cluster. Queries ran successfully and codes look good to me.

@asfgit asfgit closed this in cb9793b Jan 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants