This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1275: Optimizer pushs down non-equi filter as theta join qualifier#327
Closed
sirpkt wants to merge 2 commits into
Closed
TAJO-1275: Optimizer pushs down non-equi filter as theta join qualifier#327sirpkt wants to merge 2 commits into
sirpkt wants to merge 2 commits into
Conversation
sirpkt
changed the title
Contributor
There was a problem hiding this comment.
It would be better if you note that this line must be restored when https://issues.apache.org/jira/browse/TAJO-742 is resolved.
The TODO annotation will be helpful for the future restoration.
Contributor
|
Hi @sirpkt |
Contributor
Author
|
Thank you for the review, @jihoonson. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch prevents non-equi filter condition becomes join qualifier of child nodes.
It can avoid theta join is created as a result of filter push down.
in FilterPushDownRule.java, visitJoin() additionally checks all the join qualifier candidates from pushing down filters whether it is non-equi join qualifier or not.