This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1289: History reader fails to get the query information after a successful query execution#356
Closed
jinossy wants to merge 6 commits into
Closed
TAJO-1289: History reader fails to get the query information after a successful query execution#356jinossy wants to merge 6 commits into
jinossy wants to merge 6 commits into
Conversation
…successful query execution
…into TAJO-1289
Contributor
|
+1 Thank you for your contribution. |
Member
There was a problem hiding this comment.
In some cases, it may result in lots of histories. In that case, It will cause long latency. Later, we need to improve the paging feature in new jira.
Member
Author
There was a problem hiding this comment.
I agree with you, we should make to pagination
Member
|
The patch looks nice to me. I leave some trivial comments. |
Member
Author
|
Thanks guys for the review. I’ll commit it shortly. |
Member
Author
|
I've add two configuration following: Please review again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main problem is some corrupted history files in hdfs. TajoClient are to get a query status in finished list when a query is finished. but the finished list is a stored files
So I’ve add LRU map for a finished query caching, and fix hidden race condition bug.