TAJO-1407 Minor performance improvement of MemSortExec#426
TAJO-1407 Minor performance improvement of MemSortExec#426navis wants to merge 1 commit intoapache:masterfrom
Conversation
|
Removed JDK7 only method |
|
Looks interesting. |
There was a problem hiding this comment.
Would you mind adding some descriptions on this class?
|
Added comments and now it supports interval type. |
|
I'll review this weekend. |
There was a problem hiding this comment.
TajoDataTypes.Type is the enum type of PB. Each type already has a corresponding integer.
type.getNumber() returns an integer value corresponding to the given type, and Type.valueOf() returns a type corresponding to the given integer value.
How about use these functions?
There was a problem hiding this comment.
It's possible but I prefer switch-case block to be compact as possible as it can be. And most of types in PB enum cannot be supported by this.
|
@navis, this is truly impressive work. |
|
Revised test case, which can be fail sometimes |
|
I run the test 5 times, and it passed every time. |
|
2M rows sometimes made GCs, causing inversion of elapsed time. |
|
Oh, I think it's ok. The revised test doesn't contain any comparisons of elapsed times. |
|
Oops, sorry. I have to wait the CI result. |
Simple micro benchmark shows 15~30% performance improvement, but this uses more memory. (Also can make little difference on appearance order of non-key values, caused by different sort implementation)