This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1360: VALUES_ field in OPTIONS table of catalog store should be longer. #436
Closed
charsyam wants to merge 1 commit into
Closed
TAJO-1360: VALUES_ field in OPTIONS table of catalog store should be longer. #436charsyam wants to merge 1 commit into
charsyam wants to merge 1 commit into
Conversation
Contributor
Author
|
@hyunsik @dongjoon-hyun @ykrips |
Member
|
@ykrips I would greatly appreciate it if you finish up this request. |
|
Hello All, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest OPTIONS size as 4000, because max size of oracle varchar2 is just 4000
I researched docs for these patch.
maria: https://mariadb.com/kb/en/mariadb/varchar/
mysql: http://dev.mysql.com/doc/refman/5.7/en/char.html
postgres: http://www.postgresql.org/docs/8.3/static/datatype-character.html
derby: https://db.apache.org/derby/docs/10.7/ref/rrefsqlj41207.html
oracle: https://docs.oracle.com/cd/B28359_01/server.111/b28320/limits001.htm#i287903
(here varchar2 limit is just 4000)