Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1360: VALUES_ field in OPTIONS table of catalog store should be longer. #436

Closed
charsyam wants to merge 1 commit into
apache:masterfrom
charsyam:feature/TAJO-1360
Closed

TAJO-1360: VALUES_ field in OPTIONS table of catalog store should be longer. #436
charsyam wants to merge 1 commit into
apache:masterfrom
charsyam:feature/TAJO-1360

Conversation

@charsyam
Copy link
Copy Markdown
Contributor

I suggest OPTIONS size as 4000, because max size of oracle varchar2 is just 4000
I researched docs for these patch.

maria: https://mariadb.com/kb/en/mariadb/varchar/
mysql: http://dev.mysql.com/doc/refman/5.7/en/char.html
postgres: http://www.postgresql.org/docs/8.3/static/datatype-character.html
derby: https://db.apache.org/derby/docs/10.7/ref/rrefsqlj41207.html
oracle: https://docs.oracle.com/cd/B28359_01/server.111/b28320/limits001.htm#i287903
(here varchar2 limit is just 4000)

@charsyam
Copy link
Copy Markdown
Contributor Author

@hyunsik @dongjoon-hyun @ykrips
I'm sorry to make you confused. Thank you.

@ykrips
Copy link
Copy Markdown

ykrips commented Apr 1, 2015

@hyunsik ,
If you are unable to work on this pull request, can I finish up this request?
This issue is related to another pull request, #491 .

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Apr 2, 2015

@ykrips I would greatly appreciate it if you finish up this request.

@ykrips
Copy link
Copy Markdown

ykrips commented Apr 2, 2015

Hello All,
+1
This patch was tested with Derby, MySQL 5.1.17, MariaDB 10.0.17, PostgreSQL 8.4.18, and Oracle 12.1.0.2.0, and worked well as expected. I will commit it in a short time.

@asfgit asfgit closed this in d6735fb Apr 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants