This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1451: implement elasticsearch storage for tajo.#464
Closed
HowookJeong wants to merge 2 commits intoapache:masterfrom
Closed
TAJO-1451: implement elasticsearch storage for tajo.#464HowookJeong wants to merge 2 commits intoapache:masterfrom
HowookJeong wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
Thanks for your contribution and I suggest you to consider following opinions. First, I found that you had wrote your name and current date. But we don't write our name and some date at all class files. Thus, you need to remove your name and date. For the reference, I just reviewed the patch simply. I'll review it continuously without above comments. |
Contributor
|
Could you trigger this for Travis CI build? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm sorry.
I retried my pull request and then please review this request.