Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1338: Defines RESTful API for Clients#490

Closed
ykrips wants to merge 17 commits intoapache:masterfrom
ykrips:TAJO-1338
Closed

TAJO-1338: Defines RESTful API for Clients#490
ykrips wants to merge 17 commits intoapache:masterfrom
ykrips:TAJO-1338

Conversation

@ykrips
Copy link

@ykrips ykrips commented Apr 1, 2015

Detail API designs can be found in the following link.
https://cwiki.apache.org/confluence/display/TAJO/TAJO+REST+API

@ykrips
Copy link
Author

ykrips commented Apr 1, 2015

This patch aligned to current version of source code.

@ykrips
Copy link
Author

ykrips commented Apr 3, 2015

Testcases in travis-ci failed, but testcases in apache build servers has been passed. Please see details in the following link.
https://builds.apache.org/job/PreCommit-TAJO-Build/695//testReport/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, it looks like unused variable.

@blrunner
Copy link
Contributor

blrunner commented Apr 5, 2015

+1

Great! It looks good overall to me and I found that rest server response successfully on my laptop as follows.

$ curl -XGET 'http://localhost:26880/rest/databases'
{"databases":["default","information_schema"]}

$ curl -XGET 'http://localhost:26880/rest/databases/default/tables'
[{"tableName":"customer","external":true},{"tableName":"lineitem","external":true},{"tableName":"nation","external":true},{"tableName":"orders","external":true},{"tableName":"part","external":true},{"tableName":"partsupp","external":true},{"tableName":"supplier","external":true}]

$  curl -XGET 'http://localhost:26880/rest/cluster'
{"workers":[{"connectionInfo":{"id":-2105400716,"host":"192.168.219.106","peerRpcPort":28091,"pullServerPort":64176,"queryMasterPort":28093,"clientPort":28092,"httpInfoPort":28080},"diskSlots":0.0,"cpuCoreSlots":1,"memoryMB":1024,"usedDiskSlots":0.0,"usedMemoryMB":0,"usedCpuCoreSlots":0,"maxHeap":932184064,"freeHeap":365067488,"totalHeap":458227712,"numRunningTasks":0,"numQueryMasterTasks":0,"lastHeartbeatTime":1428221077181}]}

I leaved some trivial comments and I found unused methods in WorkerConnectionInfoResponse and WorkerResponse, too. Before you ship this, please check my comments. :)

@ykrips
Copy link
Author

ykrips commented Apr 5, 2015

@blrunner ,
I have removed unused methods in my patch. Thanks for review.

@blrunner
Copy link
Contributor

blrunner commented Apr 5, 2015

Thanks @ykrips

I found the updated patch. Finally, could you trigger this for CI build or upload the patch to JIRA?

@ykrips
Copy link
Author

ykrips commented Apr 6, 2015

No problems. I don't have any privileges on travis ci, so I will upload the patch to JIRA.

@blrunner
Copy link
Contributor

blrunner commented Apr 6, 2015

I found the result of jenkins build as following:
https://builds.apache.org/job/PreCommit-TAJO-Build/709//testReport/

Ship it. :)

@ykrips
Copy link
Author

ykrips commented Apr 6, 2015

@blrunner ,
Thanks you for quick review. This patch will commit into main branch.

@asfgit asfgit closed this in 32b524d Apr 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants