This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1560: HashShuffle report should be ignored when a succeed tasks are not included#538
Closed
jinossy wants to merge 5 commits intoapache:masterfrom
Closed
TAJO-1560: HashShuffle report should be ignored when a succeed tasks are not included#538jinossy wants to merge 5 commits intoapache:masterfrom
jinossy wants to merge 5 commits intoapache:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
It would be great if you add a comment that describes why we don't need to collect reports when the shuffle type is RANGE_SHUFFLE.
Contributor
|
+1. I just a minor comment. Please address before commit. |
Member
Author
|
Thank you for your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, I’ve remove unnecessary synchronized block in HistoryWriter