Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1577: Add test cases to verify join plans#571

Closed
jihoonson wants to merge 30 commits intoapache:masterfrom
jihoonson:TAJO-1577_2
Closed

TAJO-1577: Add test cases to verify join plans#571
jihoonson wants to merge 30 commits intoapache:masterfrom
jihoonson:TAJO-1577_2

Conversation

@jihoonson
Copy link
Contributor

This patch is based on @navis's first work (#558).
Here are the summary of changes.

  • Most join query tests are executed with the SimpleTest annotation. It includes tests of logical plan, global plan, and query execution result.
  • Join tests are categorized into 6 groups, i.e., TestInnerJoinQuery, TestInnerJoinWithSubQuery, TestOuterJoinQuery, TestOuterJoinWithSubQuery, TestMultipleJoinTypes, and TestJoinOnPartitionedTables.
    • I've newly added the NamedTest annotation to reuse files for datasets and queries.
    • Some temporal tables are shared across different join tests.
    • Every join test is executed with hash join, sort-merge join, hash-broadcast join, and sort-merge-broadcast join.

Review on Reviewable

@hyunsik
Copy link
Member

hyunsik commented May 18, 2015

Great job! The patch looks good to me. The change looks straightforward. You may spend lots of time on changing many tests.

Here is my +1.

@asfgit asfgit closed this in 4b1b779 May 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants