This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1577: Add test cases to verify join plans#571
Closed
jihoonson wants to merge 30 commits intoapache:masterfrom
Closed
TAJO-1577: Add test cases to verify join plans#571jihoonson wants to merge 30 commits intoapache:masterfrom
jihoonson wants to merge 30 commits intoapache:masterfrom
Conversation
…into TAJO-1577_2
…into TAJO-1577_2
Member
|
Great job! The patch looks good to me. The change looks straightforward. You may spend lots of time on changing many tests. Here is my +1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is based on @navis's first work (#558).
Here are the summary of changes.
SimpleTestannotation. It includes tests of logical plan, global plan, and query execution result.NamedTestannotation to reuse files for datasets and queries.