This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1618 [Rest API] queries/{queryId} should set default print type#581
Closed
charsyam wants to merge 1 commit intoapache:masterfrom
Closed
TAJO-1618 [Rest API] queries/{queryId} should set default print type#581charsyam wants to merge 1 commit intoapache:masterfrom
charsyam wants to merge 1 commit intoapache:masterfrom
Conversation
change default as COMPLICATED default value to resultset
charsyam
force-pushed
the
feature/rest-default-printtype
branch
from
6fee656 to
a8f9654
Compare
Contributor
|
It seems that there were some problems to download some maven jars. |
Contributor
Author
|
@jihoonson I attached patch on jira. |
Contributor
|
+1. Thanks @charsyam. It works well. I'll change indent before commit. |
Contributor
Author
|
@jihoonson I will update it soon. |
Contributor
Author
|
@jihoonson and I'm sorry for indent. Actually I fixed it , but I forgot push. sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently REST API /queries/
{queryId} cause error without print parameter.
and submit query just return url of /queries/{queryId}
without print type.
so I think it is better to set default print type when users don't pass print querystring.