Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1638 Remove offset parameter from rest api result/{cacheId}#599

Closed
charsyam wants to merge 8 commits intoapache:masterfrom
charsyam:feature/rest-api-remove-offset
Closed

TAJO-1638 Remove offset parameter from rest api result/{cacheId}#599
charsyam wants to merge 8 commits intoapache:masterfrom
charsyam:feature/rest-api-remove-offset

Conversation

@charsyam
Copy link
Copy Markdown
Contributor

@charsyam charsyam commented Jun 5, 2015

in result/{cacheId}
rest api.
offset parameter can make user confused.
because offset can't go back.
It's only set forward(not backward)
and add 3 new header for result response.
X-Tajo-Offset : from start offset
X-Tajo-Count: fetch count
X-Tajo-EOS: if there is end stream. it sets EOS true

clark.kang and others added 4 commits June 5, 2015 22:56
…_name}/queies to /queries.

Closes apache#598

Signed-off-by: JaeHwa Jung <blrunner@apache.org>
Closes apache#597

Signed-off-by: JaeHwa Jung <blrunner@apache.org>
@blrunner
Copy link
Copy Markdown
Contributor

@charsyam

Thanks for your contribution.
But I failed to merge this patch as following

Auto-merging tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResultResource.java
Auto-merging tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResultResource.java
CONFLICT (content): Merge conflict in tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResultResource.java
Automatic merge failed; fix conflicts and then commit the result.

Could you check it ?

@charsyam
Copy link
Copy Markdown
Contributor Author

@blrunner
HI, Thanks. I rebased it :)

@blrunner
Copy link
Copy Markdown
Contributor

+1

Thank you for your contribution.

@asfgit asfgit closed this in 773c3eb Jun 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants