Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1397: Resource allocation should be fine grained.#608

Closed
jinossy wants to merge 88 commits intoapache:masterfrom
jinossy:TAJO-1397
Closed

TAJO-1397: Resource allocation should be fine grained.#608
jinossy wants to merge 88 commits intoapache:masterfrom
jinossy:TAJO-1397

Conversation

@jinossy
Copy link
Copy Markdown
Member

@jinossy jinossy commented Jun 21, 2015

I've add SimpleScheduler to the default query scheduler, SimpleScheduler allows query execution simultaneously.
Most changes, I've remove legacy codes and enable the TAJO-1599

In details following :

Removed legacy class

TajoWorkerResourceManager
TajoResourceAllocator
TajoSimpleFifoScheduler
TaskRunner
.. related class

Resource related configuration

  • Removes
tajo.qm.resource.disk.slots
tajo.task.disk-slot.default
tajo.worker.resource.dedicated
  • Changes
tajo.qm.resource.memory-mb  to tajo.qm.resource.min.memory-mb
tajo.task.memory-slot-mb.default to tajo.task.resource.min.memory-mb
tajo.worker.resource.disks type to Integer

@jinossy
Copy link
Copy Markdown
Member Author

jinossy commented Jun 21, 2015

This PR is not ready to review. please don't start review.
I just test the Travis-CI

@jinossy jinossy changed the title TAJO-1397 TAJO-1397: Resource allocation should be fine grained. Jun 21, 2015
jihoonson
jihoonson reviewed Jul 17, 2015
View reviewed changes
Comment thread tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java Outdated
Copy link
Copy Markdown
Contributor

@jihoonson jihoonson Jul 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about defining a constant to represent an empty query master host?

@jinossy
Copy link
Copy Markdown
Member Author

jinossy commented Jul 17, 2015

I've rename Worker to NodeStatus

hyunsik
hyunsik reviewed Jul 17, 2015
View reviewed changes
Comment thread tajo-common/src/main/java/org/apache/tajo/util/TUtil.java Outdated
Copy link
Copy Markdown
Member

@hyunsik hyunsik Jul 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused.

@jinossy
Copy link
Copy Markdown
Member Author

jinossy commented Jul 18, 2015

@hyunsik
Thank you for your review
I've update the patch that reflects your comments

@jihoonson
Copy link
Copy Markdown
Contributor

jihoonson commented Jul 19, 2015

The latest patch looks good to me.

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Jul 20, 2015

LGTM. Here is my +1.

@jihoonson
Copy link
Copy Markdown
Contributor

jihoonson commented Jul 20, 2015

+1 ship it!

@asfgit asfgit closed this in 5a02873 Jul 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jinossy @jihoonson @hyunsik