Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1677: Remove unnecessary messages for the Travis CI build#625

Closed
blrunner wants to merge 18 commits intoapache:masterfrom
blrunner:TAJO-1677
Closed

TAJO-1677: Remove unnecessary messages for the Travis CI build#625
blrunner wants to merge 18 commits intoapache:masterfrom
blrunner:TAJO-1677

Conversation

@blrunner
Copy link
Contributor

@blrunner blrunner commented Jul 8, 2015

Enable -B (batch) mode on the build. This will make the logs shorter since it avoids the dependency download progress logging.

@blrunner
Copy link
Contributor Author

blrunner commented Jul 9, 2015

I've implemented this patch as follows.

  • Apply -q parameter for maven : Only show errors.
  • Apply -ff parameter for maven : Stop at first failure in reactorized builds
  • Apply surefire.useFile=false for maven: This causes surefire to print test failures to standard out.
  • Clean up TestSystemMetrics log messages.
  • Clean up TajoMaster log messages.
  • Fix TestBSTIndexExec:testEqual error.
  • Remove RestServer warning log messages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to be different to the original intension. This log appears to show which HDFS namenode is used in this TajoMaster.

@hyunsik
Copy link
Member

hyunsik commented Jul 13, 2015

The first description mentioned that -B will be added to maven option. Was the plan changed?

@hyunsik
Copy link
Member

hyunsik commented Jul 13, 2015

Please see the following volumes. quite.txt contains all messages from '-q' option. For me, -q seems to be not effective.

hyunsik@Hyunsiks-MacBook-Pro:~$ ls -l quite.txt normal.txt 
-rw-r--r--  1 hyunsik  staff  75536879 Jul 13 16:41 normal.txt
-rw-r--r--  1 hyunsik  staff  75490962 Jul 13 17:14 quite.txt

@blrunner
Copy link
Contributor Author

Hi @hyunsik

Thank you for your detailed review.
I've updated the patch using your comments.
For your information, I added -q parameter instead of -B parameter. In some unexplained way, -B parameter didn't work as expect.

@blrunner
Copy link
Contributor Author

I think that the parameter on your desktop seemed like ineffective, because tajo dependencies already had been installed on your desktop. If you see build progress of this PR, you would see that there is no dependency download progress.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to recover meaningless changes.

@hyunsik
Copy link
Member

hyunsik commented Jul 13, 2015

As I mentioned in some comments, most of changes are about coding format. You need to recover them. Coding format should be done in a separate issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants