This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1723: INSERT INTO statement should allow nested fields as target columns.#668
Closed
hyunsik wants to merge 7 commits into
Closed
TAJO-1723: INSERT INTO statement should allow nested fields as target columns.#668hyunsik wants to merge 7 commits into
hyunsik wants to merge 7 commits into
Conversation
* Improve SQL parser to recognize nested target fields in INSERT INTO statement. * Add workaround for hanging TaskContainer. * Improve logical planner to recognize nested target fields in INSERT INTO statement.
Member
Author
|
TestSelectNestedRecord contains some insertion tests. Its purpose is not matched to the class name. I wanted to merge all unit tests related to nested fields into one test. Later, I'll move them into more proper one. |
Member
|
+1 Looks great to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch improve INSERT INTO statement to allow nested fields as target columns as follows:
CREATE TABLE X (rowkey TEXT, cf1 RECORD (v1 int, v2 int)); INSERT INTO X (rowkey, cf1.v1, cf2.v1) SELECT x, y, z FROM t2