This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1740: Update Partition Table document#677
Closed
blrunner wants to merge 3 commits intoapache:masterfrom
Closed
TAJO-1740: Update Partition Table document#677blrunner wants to merge 3 commits intoapache:masterfrom
blrunner wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Explanation is same precisely as above one.
I think it's better to add some words like 'including CREATE TABLE' or 'when a partition table is created'
Contributor
|
Hi, @blrunner . I reviewed your writing documents and left some inline comments. Please check them out. |
…into TAJO-1740
…into TAJO-1740
Contributor
Author
|
Hi @eminency Thank you for your detailed review. |
Member
|
I recommend you to keep a single page for column partition. Each content is too short. Later, it may be hard to see all contents at once after we add new partition type. |
Member
|
I saw new PR. Please ignore the last comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Tajo doesn't provide enough informations about partition table. Thus, we need to add more informations to following documentation.
http://tajo.apache.org/docs/current/partitioning/column_partitioning.html