Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1745: Add positive and negative test methods.#681

Closed
hyunsik wants to merge 8 commits intoapache:masterfrom
hyunsik:TAJO-1745
Closed

TAJO-1745: Add positive and negative test methods.#681
hyunsik wants to merge 8 commits intoapache:masterfrom
hyunsik:TAJO-1745

Conversation

@hyunsik
Copy link
Copy Markdown
Member

@hyunsik hyunsik commented Aug 10, 2015

Review on Reviewable

@jinossy
Copy link
Copy Markdown
Member

jinossy commented Aug 12, 2015

Trigger travis please?

jinossy
jinossy reviewed Aug 12, 2015
View reviewed changes
Comment thread tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java Outdated
Copy link
Copy Markdown
Member

@jinossy jinossy Aug 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change to google collection?

Copy link
Copy Markdown
Member Author

@hyunsik hyunsik Aug 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Aug 12, 2015

rebased

@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Aug 13, 2015

rebased

@jinossy
Copy link
Copy Markdown
Member

jinossy commented Aug 18, 2015

Would you check failure?

  TestSelectQuery.testPositives:59->QueryTestCaseBase.runNegativeTests:508->QueryTestCaseBase.getNegativeQueryFiles:852 » IO
  TestSelectQuery.testNegatives:64->QueryTestCaseBase.runNegativeTests:508->QueryTestCaseBase.getNegativeQueryFiles:852 » I

Tests run: 69, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 68.622 sec <<< FAILURE! - in org.apache.tajo.engine.query.TestSelectQuery
testPositives(org.apache.tajo.engine.query.TestSelectQuery)  Time elapsed: 0.005 sec  <<< ERROR!
java.io.IOException: Cannot find file:/Users/jhkim/tajo/asf/tajo/tajo-core-tests/target/test-classes/queries/TestSelectQuery/nagative
        at org.apache.tajo.QueryTestCaseBase.getNegativeQueryFiles(QueryTestCaseBase.java:852)
        at org.apache.tajo.QueryTestCaseBase.runNegativeTests(QueryTestCaseBase.java:508)
        at org.apache.tajo.engine.query.TestSelectQuery.testPositives(TestSelectQuery.java:59)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)

@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Aug 19, 2015

rebased and fixed.

@jinossy
Copy link
Copy Markdown
Member

jinossy commented Aug 19, 2015

+1 LGTM

@asfgit asfgit closed this in 6f28fa5 Aug 19, 2015
asfgit pushed a commit that referenced this pull request Aug 19, 2015
@hyunsik
TAJO-1745: Add positive and negative test methods.
cb23c10 
Closes #681
@hyunsik hyunsik deleted the TAJO-1745 branch August 20, 2015 06:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyunsik @jinossy