Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1792: tajo-cluster-tests is not available when it is used as an external maven module.#704

Closed
hyunsik wants to merge 6 commits intoapache:masterfrom
hyunsik:TAJO-1792
Closed

TAJO-1792: tajo-cluster-tests is not available when it is used as an external maven module.#704
hyunsik wants to merge 6 commits intoapache:masterfrom
hyunsik:TAJO-1792

Conversation

@hyunsik
Copy link
Copy Markdown
Member

@hyunsik hyunsik commented Aug 20, 2015

Review on Reviewable

Comment thread tajo-jdbc/pom.xml
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove netty dependency?

<exclusion>
          <artifactId>netty-all</artifactId>
          <groupId>io.netty</groupId>
</exclusion>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove netty dependency in hadoop-hdfs

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@hyunsik
Copy link
Copy Markdown
Member Author

hyunsik commented Aug 20, 2015

I fixed the test failure, and reflected the comments.

@jinossy
Copy link
Copy Markdown
Member

jinossy commented Aug 20, 2015

+1 LGTM!!

@asfgit asfgit closed this in e296a0d Aug 20, 2015
asfgit pushed a commit that referenced this pull request Aug 20, 2015
@hyunsik hyunsik deleted the TAJO-1792 branch August 20, 2015 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants